[mythtv-commits] mythtv commit: r8098 by danielk

mythtv at cvs.mythtv.org mythtv at cvs.mythtv.org
Fri Dec 2 17:24:02 UTC 2005


      Author: danielk
        Date: 2005-12-02 17:24:01 +0000 (Fri, 02 Dec 2005)
New Revision: 8098
   Changeset: http://cvs.mythtv.org/trac/changeset/8098

Modified:

   trunk/mythtv/libs/libmythtv/NuppelVideoPlayer.cpp
   trunk/mythtv/libs/libmythtv/avformatdecoder.cpp

Log:

Closes #740. This should fix the segfault.

The segfault happened because SwitchToProgram() didn't
check for the being errored before resuming playback.

This adds that check in SwitchToProgram().

It also adds it to the StartPlaying() loop. This part is just
so that an error message gets displayed before we exit.

For an extra level of paranoia this also adds a check for a null
context pointer in the packet reading portion of GetFrame(). 
This prevents a segfault if GetFrame() is called when there is 
no context pointer; so long as there it is reset clearing any
buffered packets.

There are still remaining problems in LiveTV that I think are 
sufficiently canvased by the existing tickets; this just prevents
a segfault if we switch to an empty file. Addressing the creation
empty files is a seperate issue.






More information about the mythtv-commits mailing list