[mythtv-commits] Ticket #474: Initial filter in watch recordings broken

MythTV mythtv at cvs.mythtv.org
Sat Oct 15 22:46:07 UTC 2005


#474: Initial filter in watch recordings broken
----------------------------+-----------------------------------------------
 Reporter:  kuphal at dls.net  |       Owner:  cpinkham
     Type:  patch           |      Status:  new     
 Priority:  minor           |   Milestone:  0.19    
Component:  mythtv          |     Version:  head    
 Severity:  medium          |  ----------------------------+-----------------------------------------------
 Looks like [7358] broke the initial filter for watch recordings.
 cancelPopup cannot be called when displaying the initial filter because
 there isn't a popup to be canceled which is contrary to the typical
 behavior when displaying this box because it is normally called from
 another popup.  This patch fixes.

 {{{
 Index: programs/mythfrontend/playbackbox.cpp
 ===================================================================
 --- programs/mythfrontend/playbackbox.cpp       (revision 7485)
 +++ programs/mythfrontend/playbackbox.cpp       (working copy)
 @@ -3777,11 +3708,12 @@

  void PlaybackBox::showRecGroupChooser(void)
  {
 -    if (!expectingPopup)
 -        return;
 +    // This is contrary to other code because the option to display this
 +    // box when starting the Playbackbox means expectingPopup will not be
 +    // set, nor is there a popup to be canceled as is normally the case
 +    if (expectingPopup)
 +       cancelPopup();

 -    cancelPopup();
 -
      initRecGroupPopup(tr("Select Group Filter"), "showRecGroupChooser");

      QStringList groups;
 }}}

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/474>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list