[mythtv-commits] Re: Ticket #475: Problems changing channels when
using browse and Picture in Picture
MythTV
mythtv at cvs.mythtv.org
Sat Oct 15 23:24:03 UTC 2005
#475: Problems changing channels when using browse and Picture in Picture
--------------------------------+-------------------------------------------
Reporter: tahoward at nc.rr.com | Owner: ijr
Type: patch | Status: new
Priority: minor | Milestone:
Component: mythtv | Version: 0.18.1
Severity: medium | Resolution:
--------------------------------+-------------------------------------------
Comment (by tahoward at nc.rr.com):
Forgot to mention what I changed - in the original code, BrowseStart will
return without doing anything if the PiP window is active. That prevents
the browse button from appearing when the browse button is pressed. If
BrowseStart has never been called, browsemode is never set to true, and
the code to change channels when the browse window is up depends on that
being set to actually change a channel. BrowseStart now works regardless
of which window is active.
Several places in the code won't display the osd if the PiP window is
active. In the main loop, if there is a channel (or partial channel) in
the buffer and the OSD is not displaying, it will switch to that channel.
When you enter a channel in PiP mode, it accepts the first digit, the loop
sees the digit and the OSD is not up, so it changes without waiting for
another digit. I made the OSD display regardless of which window is
active in places where channel changing is involved.
Whenever it switches channels, it stores that channel. If you try to
change channels to that channel, it sees that it is the most recently
viewed channel, and does not change (since it is always there). This
doesn't take into account tuner changes, which effectively change the
channel (to whatever the tuner was set to) without going through the
channel code. I added a check to see if the tuner has been tuned to
anything yet in addition to check that the new channel is different from
the old channel. If the tuner hasn't been tuned yet, it changes channels
regardless of what the last channel seen was.
--
Ticket URL: <http://cvs.mythtv.org/trac/ticket/475>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list