[mythtv-commits] Re: Ticket #368: Teletext patch for DVB/IVTV cards
MythTV
mythtv at cvs.mythtv.org
Mon Oct 17 23:39:40 UTC 2005
#368: Teletext patch for DVB/IVTV cards
-----------------------------------------------------+----------------------
Reporter: Frank Muenchow (beebof -at- gmx dot de) | Owner: danielk
Type: patch | Status: assigned
Priority: minor | Milestone: 0.20
Component: mythtv | Version: head
Severity: low | Resolution:
-----------------------------------------------------+----------------------
Changes (by danielk):
* milestone: => 0.20
* severity: medium => low
* version: => head
* status: new => assigned
* owner: ijr => danielk
* type: enhancement => patch
Comment:
I've fixed a few things in the patch, but it still needs some care.
First, you can't inherit two QObject's, nor can you use virtual
inheritance for the QObject. So I've disabled the signals and slots in the
TeletextView class. The affected areas are marked with "FIXME" ifdef's.
Try to just use direct calls when
possible, it is too easy to make mistakes like this with Qt signals.
There was also a logic error in one of the switch statements because you
didn't use bracing for the loops, and then commented out the statement, so
it put the next couple case's inside the loops. This is fixed.
Also no TAB characters are allowed... this messes up the formatting of the
patches and makes them harder to read. I think I got rid of most of them.
For the ivtv/dvb/other test look at TV::GetLockTimeout(), if you replace
the query with "SELECT cardtype FROM capturecard WHERE cardid = :CARDID"
then you will have the card type.
Part of the mpegts.c patch was rejected, and I didn't know what you were
doing so please look at that.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/368>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list