[mythtv-commits] Ticket #2258: Deleting orphaned channels (unassigned) in channel editor removes \all\ channels

[MythTV]

#2258: Deleting orphaned channels (unassigned) in channel editor removes \all\
channels
---------------------------------------+------------------------------------
 Reporter:  knowledgejunkie at gmail.com  |       Owner:  danielk
     Type:  defect                     |      Status:  new    
 Priority:  minor                      |   Milestone:         
Component:  mythtv                     |     Version:  head   
 Severity:  medium                     |  
---------------------------------------+------------------------------------
 (Kindly note that I consider this a defect in what one would expect both
 of the general functionality and as implied by the user interface, and
 thus not a feature request).

 The current implementation of the channel editor allows one to filter
 video sources to list just those channels available on each source. If a
 source has been deleted in mythtv-setup "Video Sources" screen, any
 channels attached to that source become orphaned.

 In the mythtv-setup Channel Editor, filtering on orhpaned channels (video
 source becomes "Unassigned") and attempting to delete them 'en masse'
 results in \all\ channels defined in the database being removed, due to a
 "TRUNCATE TABLE channel" query.

 The misleading message displayed after selecting Delete ("Are you sure you
 would like to delete these channels?") - when the channel list contains a
 filtered list of the unassigned channels (surely the 'these channels' that
 the message refers to) does not help the user either.

 Would it not make sense for ChannelEditor::deleteChannels(void) to check
 whether there are any other defined video sources with attached channels
 before truncating the table completely and destroying everything? If there
 are, just delete those channels unassigned to a source; if there are not,
 truncate the channel table.

 Even from a fairly experienced MythTV user's perspective this behaviour is
 neither obvious nor clearly explained and had me quickly reaching for my
 mythconverg backup once I saw \all\ 120+ channels missing.

 Thanks,
 Nick

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/2258>
MythTV <http://www.mythtv.org/>
MythTV