[mythtv-commits] Ticket #2265: Improved audio timestamp calculation on Mac OS X

[MythTV]

#2265: Improved audio timestamp calculation on Mac OS X
-----------------------------+----------------------------------------------
 Reporter:  awk at awkward.org  |        Owner:  nigel   
     Type:  patch            |       Status:  assigned
 Priority:  minor            |    Milestone:          
Component:  mythtv           |      Version:          
 Severity:  medium           |   Resolution:          
-----------------------------+----------------------------------------------
Comment (by awk at awkward.org):

 As an alternative to a review of the class hierarchy etc. I guess the
 friend approach is OK. Although I have to say that it feels 'odd' to me to
 make a subclass a friend rather than either change the class design (or
 provide accessors to that data if it's truly supposed to be private). In
 fact that's probably the best approach - add a couple of protected
 accessors in the base class that derived classes can use to get at the
 variables - if changing the visibility is accessible.

 Regarding behaviour - are you using a backend which inherently delivers
 MPEG Transport Streams ? Something like the Firewire recorder interface to
 a settop box ? It may be in such a circumstance the audio sync is less of
 an issue.

 I'm fine with waiting 'til post 0.20 I doubt that I'll have finished
 prepping the pretty large amount of backend changes I have in time - let
 alone anyone reviewing them and wanting to commit them in that timeframe.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/2265#comment:3>
MythTV <http://www.mythtv.org/>
MythTV