[mythtv-commits] Ticket #1217: Failure to find ALSA volume control is considered fatal

[MythTV]

#1217: Failure to find ALSA volume control is considered fatal
-------------------------------------------+--------------------------------
 Reporter:  mythtv at dadeos.freeserve.co.uk  |       Owner:  ijr 
     Type:  defect                         |      Status:  new 
 Priority:  minor                          |   Milestone:      
Component:  mythtv                         |     Version:  head
 Severity:  medium                         |  
-------------------------------------------+--------------------------------
 The attached patch resolves some issue that I encountered attempting to
 configure my system to use an ALSA audio output device.

 * Bug fix: If certain volume controls are not present for a given card
 (i.e. "Master" and "PCM") then the audio device was disabled. This patch
 simply prints a debug message indicating that the controls could not be
 found.

 * Code tidy: Removed the "elem" and "sid" member variables from the class.
 These variables were only valid within certain functions of the class and
 therefore it is risky to offer them to all functions (the "sid" member in
 particular was initialised to point to a stack location of a calling
 function).

 * Enhancement: I have an M-Audio Revolution 7.1 soundcard, which uses an
 Envy24HT chipset and that exposes it's volume controls as a number of mono
 "DAC" controls, as opposed to a single multi-channel control. The existing
 code only supported controlling the volume for a multi-channel control, so
 I have added code that looks for multiple mono controls if the first
 control found does not support the channel being configured.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1217>
MythTV <http://www.mythtv.org/>
MythTV