[mythtv-commits] Re: Ticket #866: Record in LiveTV doesn't work if you leave LiveTV.

[MythTV]

#866: Record in LiveTV doesn't work if you leave LiveTV.
----------------------------------------------+-----------------------------
 Reporter:  adrian.wilkins at spamoff.gmail.com  |        Owner:  danielk 
     Type:  defect                            |       Status:  assigned
 Priority:  major                             |    Milestone:  0.19    
Component:  mythtv                            |      Version:  head    
 Severity:  medium                            |   Resolution:          
----------------------------------------------+-----------------------------
Comment (by danielk):

 Commit readers, please test the attached patch attached to this ticket.

 AFAIC This should be the last big changeset before 0.19...

 What this does is introduce the concept of a 'pseudoLiveTVRecording' which
 allows us to insert what will be a regular recording into a LiveTV chain.
 This in turn lets the LiveTV experience be more seemless, with scheduled
 recordings and marked recordings within the chain feeling to the user like
 a slightly restricted form of LiveTV. Restrictions that can be lifted by
 toggling the 'R'ecord bit off.

 When one of these regular recordings is in progress certain LiveTV
 functions such as channel changing are disabled, once this recording ends
 or you end it's special status it by toggling "R"ecord then LiveTV
 functionality resumes. You can also exit at any point during the 'regular'
 recording whether it was instanciated by pressing 'R' in LiveTV or was a
 scheduled recording you chose to watch as it started, and it will continue
 recording until it finishes or you cancel it via the normal means.

 When a scheduled recording occurs while you are watching a recording that
 you flagged for keeping as a 'regular' recording you are informed of your
 options like you normally would be. But instead of 'Record and continue
 watching' being the default, 'Cancel scheduled recording' is the the
 default. The rationale is that you would probably not want that movie you
 just flagged for keeps to be cancelled so that one of your many recording
 rules could be obeyed.

 This does change the MythTV protocol, it adds a parameter to ASK_RECORDING
 and to CANCEL_NEXT_RECORDING, and adds a new tv_rec to tv_play message
 "LIVETV_WATCH". The first two are to support making 'Cancel scheduled
 recording' the default after you mark a LiveTV recording as a 'regular'
 recording. "LIVETV_WATCH" is mostly to tell the frontend whether to enable
 or disable things like channel changing, but it is also used to change the
 channel in LiveTV to get ready for a scheduled recording, when the user is
 in when it begins LiveTV and hasn't canceled the recording.


 I tested the following with both NuppelVideoRecorder and DVBRecorder:

 {{{
 "R"ecord:
   * exits correctly at end of program      ? Yes
   * exits correcting if you leave livetv   ? Yes
 Scheduled Record while in LiveTV
   * starts correctly if you were
     watching different channel             ? Yes
   * starts correctly if you were
     watching same channel                  ? Yes
     NOTE: This does a channel change, which isn't really needed...
   * exits correctly at end of program      ? Yes
   * exits correcting if you leave livetv   ? Yes

 "R"ecorded program can cancel conflicting Scheduled Recordings?
   * during LiveTV                          ? Yes
      + starts recording                    ? Yes
      + reschedule doesn't cause scheduled
        unwanted recording restart          ? Yes
   * after LiveTV exit (before notify)      ? Yes
   * after LiveTV exit (after notify)       ? Yes

 "R"ecorded program can allow conflicting Scheduled Recording to proceed
   * in LiveTV                              ? Yes
   * by exiting and abandoning recording    ? Yes
 }}}

 Plus, some other things I tested less systematically along the way...

 What hasn't been well tested is just everyday use; for instance,
 practically all my conflicting scheduled recordings were created by
 inserting manual recordings.

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/866>
MythTV <http://www.mythtv.org/>
MythTV