[mythtv-commits] Ticket #1052: Backend segfault in preview generation

[MythTV]

#1052: Backend segfault in preview generation
-------------------------------------+--------------------------------------
 Reporter:  justifiably at cwazy.co.uk  |        Owner:  danielk
     Type:  defect                   |       Status:  closed 
 Priority:  major                    |    Milestone:  0.20   
Component:  mythtv                   |      Version:  head   
 Severity:  medium                   |   Resolution:  fixed  
-------------------------------------+--------------------------------------
Changes (by danielk):

  * resolution:  => fixed
  * status:  new => closed

Comment:

 (In [8651]) Fixes #1052.

 In this case an MPEG-4 recording is using a frame height which is not a
 multiple of 16. ffmpeg isn't doing any validation on the dimensions so it
 ends up writing outside the buffer. This just pads allocated buffers up to
 multiples of 16, so that this type of error doesn't cause a segfault with
 any of the codecs we support. MythTV does prevent you from setting an
 invalid dimension when you record to a MPEG-4 NUV, so AFAIK this is more
 of a legacy issue.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1052>
MythTV <http://www.mythtv.org/>
MythTV