[mythtv-commits] Ticket #1907: Patch to keep dvbsignalmonitor sectionreader in line

MythTV mythtv at cvs.mythtv.org
Fri Jun 2 22:41:40 UTC 2006


#1907: Patch to keep dvbsignalmonitor sectionreader in line
----------------------------------------+-----------------------------------
 Reporter:  mythdev at penyball.cix.co.uk  |        Owner:  danielk 
     Type:  patch                       |       Status:  reopened
 Priority:  minor                       |    Milestone:  0.20    
Component:  mythtv                      |      Version:  head    
 Severity:  low                         |   Resolution:          
----------------------------------------+-----------------------------------
Changes (by mythdev at penyball.cix.co.uk):

  * resolution:  invalid =>
  * status:  closed => reopened

Comment:

 agreed this was an attempt to minimise changes & the horrid cc hack works
 around the assembly ... sorry  :)

 Attached is a HandlePESTable - A ProcessPESData & ProcessPESPacket
 equivalent feels unnecessary - ymmv!

 The PESPacket constructor used by this patch chopped the last byte of the
 checksum when copying in the pesdata. (Or I've misunderstood again) I've
 amended this but cannot find any other call to this constructor to test
 the effect.

 If the constructor is not actually used anywhere else then it feels like
 the call to InitPESPacket should be replaced by a call to SetPSIOffset  -
 in any case the line addinga recalculation of _badPacket ought to be
 needed because the buffers have been overwritten.

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/1907>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list