[mythtv-commits] Ticket #603: Removable media support in MythGallery

[MythTV]

#603: Removable media support in MythGallery
-------------------------------------------------------+--------------------
 Reporter:  Aaron McCarthy <mccarthy.aaron at gmail.com>  |        Owner:  danielk 
     Type:  enhancement                                |       Status:  assigned
 Priority:  minor                                      |    Milestone:  0.20    
Component:  mythgallery                                |      Version:  head    
 Severity:  medium                                     |   Resolution:          
-------------------------------------------------------+--------------------
Comment (by Aaron McCarthy <mccarthy.aaron at gmail.com>):

 I have just uploaded two new files which I believe addresses most of the
 issues.

 Could you clarify these three remaining points
 // Allow wholesale clearing of marks
 As per my last comment to this ticket there is a menu option that I
 believe does this.

 // Exit "Show Devices" on exit from submenu
 I'm not sure this is needed, and may cause problems.  If you exit from
 "Show Devices" when you exit the menu how do you browse into the device?

 // Avoid using #define and #ifdef when possible.
 I believe I have minimised the use of ifdefs

 The final patch now consists of 4 parts
 gallery_blue_theme.diff
 gallery-mark.png
 mythmedia_locking.diff
 gallery_removable_v5.diff

 Improvements I have made in this version:
 I've added locking functions to MediaMonitor.  Other threads can now pass
 around and store MythMediaDevice pointers without locking.  Before
 dereferencing the pointer, calling member functions etc the pointer must
 be validated and locked, when finished it should be unlocked.  I have
 fixed up all places that use MythMediaDevices in mythtv and mythplugins to
 use this scheme.

 I've implemented GalleryUtil::FileCopy and GalleryUtil::FileMove using
 library functions instead of calling external commands.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/603>
MythTV <http://www.mythtv.org/>
MythTV