[mythtv-commits] Ticket #1733: Fix 3 small metadata related bugs in MythMusic

MythTV mythtv at cvs.mythtv.org
Sun May 14 17:52:55 EDT 2006


#1733: Fix 3 small metadata related bugs in MythMusic
---------------------------------------------------+------------------------
 Reporter:  Colin Guthrie <mythtv at colin.guthr.ie>  |        Owner:  ijr 
     Type:  patch                                  |       Status:  new 
 Priority:  minor                                  |    Milestone:  0.20
Component:  mythmusic                              |      Version:  head
 Severity:  medium                                 |   Resolution:      
---------------------------------------------------+------------------------
Changes (by Colin Guthrie <mythtv at colin.guthr.ie>):

  * milestone:  => 0.20
  * summary:  Fix removal of stale metadata in mythmusic's scan => Fix 3
              small metadata related bugs in MythMusic
  * version:  => head

Comment:

 Please now ignore the first patch "remove_stale_metadata.diff".

 While the new diff addresses three kinda separate issues, the patch is
 combined as the issues are very simple to analyse in diff format and are
 all related to metadata handling.

 Description:

 The fixes in mythmusic/metadata.cpp address the incorrect usage of the
 method QString::remove which will actually edit the original data which is
 not what is intended. This corrects this thinko.

 The fixes in mythmusic/editmetadata.cpp are a cosmetic change which will
 prevent certain options relating to saving metadata appearing when the
 filename contains :// (somewhat odd considering MM on it's own does not
 allow this to happen but I presume MFD does as there is special
 consideration for :// in other areas of the code).

 The fixes in mythmusic/main.cpp is the same fix as originally posted but
 uses the same variable name as used in two places in metadata.cpp for
 consistency. Fixes the removal of stale metadata from the DB during scan.

 If someone feels like it's worth it, this can probably go into fixes
 without conflict (tho' not tested).

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1733>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list