[mythtv-commits] Ticket #1826: consecutive recordings in mythtv-eit broken

[MythTV]

#1826: consecutive recordings in mythtv-eit broken
--------------------------------------------+-------------------------------
 Reporter:  Janne <janne-mythtv at grunau.be>  |        Owner:  danielk
     Type:  patch                           |       Status:  closed 
 Priority:  minor                           |    Milestone:  0.20   
Component:  dvb                             |      Version:  head   
 Severity:  medium                          |   Resolution:  fixed  
--------------------------------------------+-------------------------------
Changes (by danielk):

  * resolution:  => fixed
  * status:  new => closed

Comment:

 (In [9939]) Fixes #1826, breakage of consecutive recording in mythtv-eit
 branch.

 This turns out to be a fairly simple race condition.

 In the EIT branch we were calling tuningRequest.deque() before
 TuningShutdowns(). But this is unsafe because we release the
 stateChangeLock when shutting down a recorder; so if another thread is in
 WaitForEventThreadSleep(), it can exit the wait before we finish tearing
 down the recorder. The fix is to just use front() to get the tuning data
 early enough for our uses in HandleTuning() and call deque() after we've
 returned from TuningShutdowns().

 The patch itself is two lines of code change plus two lines of exposition.

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/1826>
MythTV <http://www.mythtv.org/>
MythTV