[mythtv-commits] Ticket #2567: mythfilldatabase incorrectly parses "rating" in XMLTV

[MythTV]

#2567: mythfilldatabase incorrectly parses "rating" in XMLTV
-----------------------+----------------------------------------------------
 Reporter:  Max Barry  |       Owner:  ijr    
     Type:  defect     |      Status:  new    
 Priority:  minor      |   Milestone:  unknown
Component:  mythtv     |     Version:  0.20   
 Severity:  low        |  
-----------------------+----------------------------------------------------
 XMLTV can include multiple <rating> tags for a single program, for
 example:
 {{{
   <programme ...
      <rating system="ABA">
        <value>M</value>
      </rating>
      <rating system="advisory">
        <value>Adult Themes</value>
      </rating>
      <rating system="advisory">
        <value>Violence</value>
      </rating>
      <rating system="advisory">
        <value>Drug Use</value>
      </rating>
 }}}
 mythfilldatabase tries to concatenate these together, but the database
 schema allows only 8 characters. The result is that the rating for this
 program in MythTV looks like this: "Adult th".

 From {mythtv}/programs/mythfilldatabase/filldata.cpp:
 {{{
                 // again, the structure of ratings seems poorly
 represented
                 // in the XML.  no idea what we'd do with multiple values.

                 ProgRating rating;
                 rating.system = info.attribute("system", "");
                 rating.rating = getFirstText(item);
                 if ("" != rating.system)
                     pginfo->ratings.append(rating);
 }}}
 ... and from the mythconverg.programrating table:
 {{{
       rating                   CHAR(8) NOT NULL
 }}}
 Ideally, MythTV should be able to display the rating as: "(M) Adult
 Themes, Violence, Drug Use". Failing that, mythfilldatabase should
 probably drop ratings using the "advisory" system when there's an
 alternative present, since "M" is more informative than "Adult Th".

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/2567>
MythTV <http://www.mythtv.org/>
MythTV