[mythtv-commits] Ticket #2544: Move mythfilldatabase cleanup tasks to the housekeeper

[MythTV]

#2544: Move mythfilldatabase cleanup tasks to the housekeeper
----------------------------------------------+-----------------------------
 Reporter:  sphery <mtdean at thirdcontact.com>  |        Owner:  cpinkham
     Type:  patch                             |       Status:  new     
 Priority:  minor                             |    Milestone:  unknown 
Component:  mythtv                            |      Version:  0.20    
 Severity:  medium                            |   Resolution:          
----------------------------------------------+-----------------------------
Comment (by sphery <mtdean at thirdcontact.com>):

 After Daniel moved all of the mythfilldatabase functionality around
 ([11619]), the previously supplied patches are no longer valid.  The
 updated patch, mythtv-cleanup_program_listings_through_housekeeper-
 post_11619.patch , should be used now, instead.

 The new patch is significantly simpler than the previous patches, since
 the program listings table cleanup is now in libmythtv.  There's no longer
 a modification to the way mythfilldatabase is run or the need for the
 MFDStruct for passing arguments to be used for calling mythfilldatabse in
 the MFDThread.  Also, there's no need for adding a "--do-cleanup-only"
 argument to mythfilldatabase since mythfilldatabase now simply coordinates
 the population/cleanup of program listings--we can completely bypass
 mythfilldatabase for the cleanup.

 Also, the new patch does not break out the cleanup of program listings
 data from cleanup of recording rules and cleanup of oldrecorded.  Cleanup
 of listings, recording rules, and oldrecord remains together in
 clearOldDBEntries() (which was simply moved from filldata.cpp to
 programdata.cpp in Daniel's commit).  After this patch is committed, I'll
 see about moving them (as a pedantic change--since they're not actually
 program listings data) to a more appropriate location (will discuss this
 more in IRC).

 Finally, because there is no longer a need to change how mythfilldatabase
 is run, changing how mythfilldatabase is found no longer conflicts with
 these changes.  Therefore, I created another ticket, #2622, to change how
 mythfilldatabase is found.

 I'm also attaching a patch, mythtv-programdata-cleanup_message.patch,
 which prefixes the message, "Keeping 7 days of data." with, "Listings
 Cleanup:".  Without this change, the message, output by
 clearOldDBEntries() and written to the backend log when cleanup is
 performed by the housekeeper, would likely scare users, who may think they
 will lose recordings and other data that's older than 7 days.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/2544#comment:2>
MythTV <http://www.mythtv.org/>
MythTV