[mythtv-commits] Ticket #3077: Default CD Device selection
MythTV
mythtv at cvs.mythtv.org
Mon Feb 12 09:52:15 UTC 2007
#3077: Default CD Device selection
--------------------------------+-------------------------------------------
Reporter: devel at mrwire.co.uk | Owner: ijr
Type: patch | Status: new
Priority: minor | Milestone: unknown
Component: mythtv | Version: head
Severity: medium | Resolution:
--------------------------------+-------------------------------------------
Comment (by nigel):
Small review
[[BR]]
1) I agree that having a default device selector is useful, and having the
burning functions seperate is also good. Having four defaults seems
overkill, though? Maybe just one DefaultBurner setting?
[[BR]]
2) Most of your code compares the *DeviceLocation setting to "default",
and then looks up another setting. Why not just use the first setting?
(''i.e.'' make the UI GetCDROMBlockDevices changes in
programs/mythfrontend/globalsettings.cpp)
[[BR]]
3) mythvideo/mythvideo/main.cpp adds "/2" onto the URL/URI/MRI/thingy.
Why? Doesn't this always force one particular track?
[[BR]]
4) Prepending /dev into the paths in the GUI selectors is a bit wasteful,
and won't work on Windows or Mac OS X. (Note, however, that I do something
equally bad in mythvideo/main.cpp on OS X). Maybe a new method,
MythMediaMonitor::GetCDMedias() that already prepends this for appropriate
OSs?
[[BR]]
5) I am wondering if the user really needs the /dev name in the GUI
selector? Ideally, we would present the device name (''e.g.'' "PIONEER
DVD-RW DVR-108" or "LITE-ON DVDRW SOHW-832S") parsed from
/proc/ide/hd?model
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/3077#comment:1>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list