[mythtv-commits] Ticket #3655: Commercial skipping for DVDs

[MythTV]

#3655: Commercial skipping for DVDs
-------------------------+--------------------------------------------------
 Reporter:  anonymous    |        Owner:  paulh  
     Type:  enhancement  |       Status:  new    
 Priority:  minor        |    Milestone:  unknown
Component:  mytharchive  |      Version:  head   
 Severity:  medium       |   Resolution:         
  Mlocked:  0            |  
-------------------------+--------------------------------------------------

Comment(by robsbox at optonline.net):

 Wow, let me see if I can address all of the issues/questions.

 I will check my patch against the latest, then reapply and test, then
 resubmit a patch to this ticket.  Might take me a while, but who knows
 whether it will yet again get obsoleted in the meantime by revisions,
 since I do not have the power to check it in.

 [Rob steps on soapbox]

 I have no knowledge of the UI, nor how to change it so that this is
 "optional."  But why should it be optional?  The current system generates
 chapter marks evenly spaced at 5% intervals throughout the content.  If
 the viewer hits the next track button, the content will skip to the next
 5% spot in the recording, which may or may not be where she wants to go,
 and most likely wont be at the end of a commercial break.

 With my patch, a user viewing the recording will come upon content that
 she does not wish to view.  By hitting the next track button, the viewer
 will advance in the content to the next chapter point.  Hopefully, the
 chapter point will have been properly detected by the commercial detection
 system, but if not, nothing gained and nothing lost -- the viewer can
 easily revert to a random-accessed position in the recording.

 So, why does this need to be optional?

 Furthermore, I take no credit for how well or poor commflagging functions.
 My view is that this automation should be made as user-friendly and hands-
 off as possible -- something that the Linux developer community in general
 seems to ignore.  This is why I am totally against basing this on the so-
 called "cut-points" in the recording -- because one must watch the
 recording and manually set these points, which is neither hands-off
 automated, nor does it make sense.  Who wants to record content that they
 already watched?  Somebody does, but if they are marking cut points, then
 they can discard the commercials entirely with the existing functionality
 already present in mytharchive, which is why this suggestion does not make
 sense.

 [Rob steps off soapbox]

 I've watched a DVD that I burned using mytharchive and this patch, the
 program having four 30 minute televison programs that I recorded with the
 commercial automarking feature enabled.  I was able to hit the next track
 button when the commercial break started, and since commflagging did a
 fantastic job, I skipped all the commercial content (including adds for
 Tivo, I might add :).  So, it works well.

 I'm not sure what you mean Paul by the themes having 8 chapters, but maybe
 that has something to do with burning movies, which is not something that
 I do.  As I recall, the existing code slices up the next chapter points at
 5% increments.  If we use mytharchive to burn something other than
 television programs, then maybe I can see your point regarding making this
 optional.  But as I said, I'm really sorry and can't do it because I don't
 have the skills or the time to acquire them.

 Please let me know what you'dlike me to do (within my capabilities) and
 I'll be happy to help out.  In the meantime, I'll generate another patch
 to satisfy Mr._Grieves, and maybe you should take a peek at my patch and
 provide me with suggestions for improvement :)

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3655#comment:3>
MythTV <http://svn.mythtv.org/trac>
MythTV