[mythtv-commits] mythtv commit: r14068 by danielk

[mythtv at cvs.mythtv.org]

      Author: danielk
        Date: 2007-07-27 21:46:32 +0000 (Fri, 27 Jul 2007)
New Revision: 14068
   Changeset: http://cvs.mythtv.org/trac/changeset/14068

Modified:

   branches/mythtv-vid/libs/libmythtv/NuppelVideoPlayer.cpp
   branches/mythtv-vid/libs/libmythtv/decoderbase.h
   branches/mythtv-vid/libs/libmythtv/videoout_directfb.cpp
   branches/mythtv-vid/libs/libmythtv/videoout_directfb.h
   branches/mythtv-vid/libs/libmythtv/videoout_dx.cpp
   branches/mythtv-vid/libs/libmythtv/videoout_dx.h
   branches/mythtv-vid/libs/libmythtv/videoout_ivtv.cpp
   branches/mythtv-vid/libs/libmythtv/videoout_ivtv.h
   branches/mythtv-vid/libs/libmythtv/videoout_null.cpp
   branches/mythtv-vid/libs/libmythtv/videoout_null.h
   branches/mythtv-vid/libs/libmythtv/videoout_quartz.cpp
   branches/mythtv-vid/libs/libmythtv/videoout_quartz.h
   branches/mythtv-vid/libs/libmythtv/videoout_xv.cpp
   branches/mythtv-vid/libs/libmythtv/videoout_xv.h
   branches/mythtv-vid/libs/libmythtv/videooutbase.cpp
   branches/mythtv-vid/libs/libmythtv/videooutbase.h

Log:

Refs #2287. This makes 3 changes to the VideoOutput::InputChanged() and a complimentary change to VideoOutput::Create().

The main change is to add a new param "codec_private". The OS X DVDV playback renderer needs access to the DVDV decoder which is created in AvFormatDecoder. This allows this data to be passed to VideoOutputQuartz in a generic way which we could reuse in the future without changing the InputChanged() signature again.

The two smaller changes were things I've wanted in the API for a while, but were too trivial to make the API change for alone. The changes are to: (1) return a ok/failed status from InputChanged(). Changing the resolution of a video can fail if the resolution exceeds what the hardware is capable of, as in #3680. In [14009], I was able to check the error status after calling InputChanged() to avoid the segfault. But actually returning this information is much nicer API wise. (2) The other is to use a QSize for the dimensions of the video, this avoids us needing to convert from QSize to ints and back to QSize when calling InputChanged().

Finally, VideoOutput::Create() just had the "codec_private" paramater added so that we can pass the initial information in when creating a VideoOutput instance. This wasn't added to VideoOutput::Init() since we can just pass the codec_private into the constructors that need it and keep the changeset much smaller.