[mythtv-commits] Ticket #3154: CD Ripper mysql errors

[MythTV]

#3154: CD Ripper mysql errors
-----------------------+----------------------------------------------------
 Reporter:  stuartm    |       Owner:  ijr    
     Type:  defect     |      Status:  new    
 Priority:  minor      |   Milestone:  unknown
Component:  mythmusic  |     Version:  0.20   
 Severity:  medium     |  
-----------------------+----------------------------------------------------
 If either, Artist, Album or Title are empty then the query in
 Ripper::isNewTune causes an error.
 {{{
 QMYSQL3: Unable to execute query
 Database error was:
 Got error 'empty (sub)expression' from regexp
 }}}

 I'm not exactly sure I understand the expected behaviour of this function.
 The REGEXPs seem unlikely to match anything other than an exact match, in
 which case wouldn't straight matching be a better choice? Or if ignoring
 punctuation etc is important, then LIKE is probably preferable.

 I've attached a patch which uses bindValues and LIKE, together with some
 checks to see that the artist/album/title aren't empty if it's any use.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3154>
MythTV <http://www.mythtv.org/>
MythTV