[mythtv-commits] Ticket #3161: Fix for wrongly sized live preview in guide

MythTV mythtv at cvs.mythtv.org
Sat Mar 3 18:27:26 UTC 2007


#3161: Fix for wrongly sized live preview in guide
----------------------------------------+-----------------------------------
 Reporter:  <celston AT katalix D com>  |       Owner:  ijr    
     Type:  defect                      |      Status:  new    
 Priority:  minor                       |   Milestone:  unknown
Component:  mythtv                      |     Version:  head   
 Severity:  low                         |  
----------------------------------------+-----------------------------------
 I noticed that If I had a letterbox format setting other than "Off", and
 then went into the guide - that the live video preview wouldn't always
 stay contained within the range specified in the theme ("current_video"
 field in ui.xml).  For example, if I have the letterbox set to wide, and
 then go into the guide, the current_video displayis wider than the size
 specified and obscures some of the surrounding theme.

 The attached patch turns any letterbox setting in the embedded NVP off
 when we go into the guide, and then returns it to the previous setting
 once we exit the guide.  The usual OSD message giving the new letterbox
 setting is inhibited because the user shouldn't need to know.

 Notes:[[BR]]
 - Exposes the existing TV::ToggleLetterbox function as public (which used
 to be private) - this may or may not be a bad thing - opinions?[[BR]]
 - It adds a new public function TV::ToggleLetterbox(int, bool), where the
 second parameter allows us to inhibit the OSD display caused when you
 change letterbox setting.[[BR]]
 - It adds a new public function TV::GetLetterbox to allow the guide grid
 to get the previous letterbox state.[[BR]]


 I've CC'd who I think the mythui maintainer is, if I've got it wrong,
 please let me know :-)

 Cheers,

 Chris.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3161>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list