[mythtv-commits] Ticket #3405: ALSA input for analog capture
MythTV
mythtv at cvs.mythtv.org
Fri May 4 12:23:37 UTC 2007
#3405: ALSA input for analog capture
-----------------------+----------------------------------------------------
Reporter: anonymous | Owner: ijr
Type: patch | Status: new
Priority: minor | Milestone: 0.21
Component: mythtv | Version: head
Severity: medium | Resolution:
-----------------------+----------------------------------------------------
Comment(by amistry at uwaterloo.ca):
Stuart: You're right, it is broken, but only with respect to logging
info. The point of the repeated checking is to give the function a single
return point at the end of the function. This way, I only have to do any
potential cleanup at one point, at the end. All the 'if (0 <= retval)' is
there to make sure further code only executes if everything up until that
point is OK. If it's not, it'll be skipped and a return code of < 0
(usually -1) will signify an error. You'll notice all the functions I've
wrote are like that inclusing the alsa input. If for some reason this is
unacceptable, I can rework the patch to put returns after each error
instead of just at the end.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/3405#comment:2>
MythTV <http://svn.mythtv.org/trac>
MythTV
More information about the mythtv-commits
mailing list