[mythtv-commits] Ticket #4132: In some menu's ESCAPE action is not handled appropriately

MythTV mythtv at cvs.mythtv.org
Wed Nov 7 20:59:18 UTC 2007


#4132: In some menu's ESCAPE action is not handled appropriately
---------------------+------------------------------------------------------
 Reporter:  danielk  |        Owner:  danielk
     Type:  patch    |       Status:  new    
 Priority:  minor    |    Milestone:  0.21   
Component:  mythtv   |      Version:  head   
 Severity:  medium   |   Resolution:         
  Mlocked:  0        |  
---------------------+------------------------------------------------------

Comment(by danielk):

 paulh, the problem is that even prior to [14478] about 2/3 of the places
 the dialogs are used we expect a 0 on reject. This is the Qt reject value,
 and depending on how you create the dialog you get different reject
 values. A lot of places are coded for the wrong return value (-1 or 0) on
 the escape key. Some places just segfault if you hit escape to get rid of
 the menu, because they don't check the range of the return and use it as
 an index into a list or an array.

 In the last patch I used the C++ typing system to find all uses of the
 exec() return value. It helped me find several segfault cases and found
 the broken examples (except for the cancel/reject SLOT problem). In the
 next patch I'll remove the "DialogCode" class and remove the unnecessary
 changes it forced. Then I'll test every different type of dialog and all
 test all the "TODO checkme" points I marked in the code this time around.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4132#comment:2>
MythTV <http://svn.mythtv.org/trac>
MythTV


More information about the mythtv-commits mailing list