[mythtv-commits] mythtv commit: r14874 - in trunk by danielk

[mythtv at cvs.mythtv.org]

      Author: danielk
        Date: 2007-11-15 18:55:30 +0000 (Thu, 15 Nov 2007)
New Revision: 14874
   Changeset: http://cvs.mythtv.org/trac/changeset/14874

Modified:

   trunk/mythplugins/mytharchive/mytharchive/archiveutil.cpp
   trunk/mythplugins/mytharchive/mytharchive/exportnativewizard.cpp
   trunk/mythplugins/mytharchive/mytharchive/logviewer.cpp
   trunk/mythplugins/mytharchive/mytharchive/main.cpp
   trunk/mythplugins/mytharchive/mytharchive/mythburnwizard.cpp
   trunk/mythplugins/mytharchive/mytharchive/recordingselector.cpp
   trunk/mythplugins/mytharchive/mytharchive/thumbfinder.cpp
   trunk/mythplugins/mytharchive/mytharchive/videoselector.cpp
   trunk/mythplugins/mythbrowser/mythbrowser/tabview.cpp
   trunk/mythplugins/mythflix/mythflix/mythflix.cpp
   trunk/mythplugins/mythflix/mythflix/mythflixqueue.cpp
   trunk/mythplugins/mythgallery/mythgallery/iconview.cpp
   trunk/mythplugins/mythgallery/mythgallery/main.cpp
   trunk/mythplugins/mythgame/mythgame/gamehandler.cpp
   trunk/mythplugins/mythgame/mythgame/gametree.cpp
   trunk/mythplugins/mythmovies/mythmovies/moviesui.cpp
   trunk/mythplugins/mythmusic/mythmusic/cdrip.cpp
   trunk/mythplugins/mythmusic/mythmusic/databasebox.cpp
   trunk/mythplugins/mythmusic/mythmusic/editmetadata.cpp
   trunk/mythplugins/mythmusic/mythmusic/filescanner.cpp
   trunk/mythplugins/mythmusic/mythmusic/importmusic.cpp
   trunk/mythplugins/mythmusic/mythmusic/main.cpp
   trunk/mythplugins/mythmusic/mythmusic/playbackbox.cpp
   trunk/mythplugins/mythmusic/mythmusic/playlist.cpp
   trunk/mythplugins/mythmusic/mythmusic/smartplaylist.cpp
   trunk/mythplugins/mythnews/mythnews/mythnews.cpp
   trunk/mythplugins/mythphone/mythphone/phoneui.cpp
   trunk/mythplugins/mythvideo/mythvideo/fileassoc.cpp
   trunk/mythplugins/mythvideo/mythvideo/main.cpp
   trunk/mythplugins/mythvideo/mythvideo/videodlg.cpp
   trunk/mythplugins/mythvideo/mythvideo/videomanager.cpp
   trunk/mythplugins/mythvideo/mythvideo/videoscan.cpp
   trunk/mythplugins/mythvideo/mythvideo/videotree.cpp
   trunk/mythplugins/mythweather/mythweather/sourceManager.cpp
   trunk/mythplugins/mythzoneminder/mythzoneminder/zmevents.cpp
   trunk/mythtv/libs/libmyth/dialogbox.h
   trunk/mythtv/libs/libmyth/mythcontext.cpp
   trunk/mythtv/libs/libmyth/mythdialogs.cpp
   trunk/mythtv/libs/libmyth/mythdialogs.h
   trunk/mythtv/libs/libmythtv/NuppelVideoPlayer.cpp
   trunk/mythtv/libs/libmythtv/customedit.cpp
   trunk/mythtv/libs/libmythtv/previouslist.cpp
   trunk/mythtv/libs/libmythtv/proglist.cpp
   trunk/mythtv/libs/libmythtv/programinfo.cpp
   trunk/mythtv/libs/libmythtv/videosource.cpp
   trunk/mythtv/libs/libmythtv/viewschdiff.cpp
   trunk/mythtv/programs/mythfrontend/channelrecpriority.cpp
   trunk/mythtv/programs/mythfrontend/custompriority.cpp
   trunk/mythtv/programs/mythfrontend/main.cpp
   trunk/mythtv/programs/mythfrontend/programrecpriority.cpp
   trunk/mythtv/programs/mythtv-setup/main.cpp

Log:

Refs #4115. Refs #4132. Changes explicit deletes of three dialogs to deleteLater() calls.

Like [14862] which addressed this problem for MythDialog, this addresses the delete problem for three children of MythDialog, MythProgressDialog, MythBusyDialog, and DialogBox. As explained in the comments on [14858] and [14862] deleting these dialogs explicitly can allow signals to arrive for the dialog after it has been deleted causing segfaults. This is hard to do when using a keyboard and mouse to provide input, but much easier to trigger when using network control to send key commands to the UI.

This only fixes 3 dialogs and the change appears much larger than it in fact is. I'm not doing all the dialogs at once so that I can roll back a just a few at a time if there are any problems. If you have an outside plugin that fails to compile after this changeset, you probably just need to change some 'delete dialogname;' expressions to 'dialogname->deleteLater();'.

This does change the myth binary revision so plugins will have to be recompiled.