[mythtv-commits] Ticket #3966: TVRec::CheckChannelPrefix erroneously detecting channels with underscore spacer

[MythTV]

#3966: TVRec::CheckChannelPrefix erroneously detecting channels with underscore
spacer
-------------------------------------------------------+--------------------
 Reporter:  Tom Dexter <digitalaudiorock at hotmail.com>  |        Owner:  danielk 
     Type:  defect                                     |       Status:  assigned
 Priority:  minor                                      |    Milestone:  0.21    
Component:  mythtv                                     |      Version:  head    
 Severity:  medium                                     |   Resolution:          
  Mlocked:  0                                          |  
-------------------------------------------------------+--------------------

Comment(by danielk):

 Ismael & Tom, can you test the attached patch. It attempts to be more
 aggressive in finding a match.

 The logic of the first part is that if fchannum[i] != add_spacer(prefix,
 fspacer[i]) then there are more characters after the prefix in the channel
 and more characters would be useful. Since we check with the "" (blank)
 spacer, this will encompass all channels with additional characters in the
 string.

 The removal of the "if (fcardid[i] != cardid) break;" in the last commit
 loop means we will commit channels on other recorders even if we need to
 add a spacer. This I'm still a bit uncertain of, because we don't check if
 a recorder is actually available for recording before doing this.
 TV::ChangeChannel() will do this, but we could actually choose
 needed_spacer so as to prefer an available recorder, which
 TV::ChangeChannel() can not do. This is no worse than the current
 behavior, but we could do better without much more work.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3966#comment:18>
MythTV <http://svn.mythtv.org/trac>
MythTV