[mythtv-commits] Ticket #3834: Patches MythWeb Weather module to use new MythWeather-revamp sources
MythTV
mythtv at cvs.mythtv.org
Tue Sep 25 05:53:46 UTC 2007
#3834: Patches MythWeb Weather module to use new MythWeather-revamp sources
-----------------------------------------------+----------------------------
Reporter: Joe Ripley <vitaminjoe at gmail.com> | Owner: xris
Type: enhancement | Status: new
Priority: minor | Milestone: unknown
Component: mythweb | Version: unknown
Severity: low | Resolution:
Mlocked: 0 |
-----------------------------------------------+----------------------------
Comment(by xris):
There are a handful of small broken things in the patch (mostly just
rewriting the svn auto-generated headers at the top of the files).
Anyway, aside from little stuff like the fact that you have "code" in the
tmpl directory (tmpl/default/set_screen.php) -- template files shouldn't
call other template files other than tiny snippets, use the main module
controller for that -- the settings screen doesn't actually seem to work
-- no inactive screens are listed to be added to the group.
Other nitpicky things:
* Use <label> tags (active screens)
* use ' instead of " when there isn't any interpretation going on (I
actually use them
differently to tell if I should expect interpreted characters).
* don't leave ?> at the end of files -- it leads to problematic
whitespace at the end of
the file that makes tracking down "output started at..." type errors.
* Don't use \t in strings when the rest of the code is using spaces, it
leads to ugly html
source.
Also, what files are no longer needed as part of this?
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/3834#comment:3>
MythTV <http://svn.mythtv.org/trac>
MythTV
More information about the mythtv-commits
mailing list