[mythtv-commits] Ticket #3334: Allow mythtv-setup to use the downloadable icons from the new online database

[MythTV]

#3334: Allow mythtv-setup to use the downloadable icons from the new online
database
-----------------------+----------------------------------------------------
 Reporter:  anonymous  |        Owner:  stuartm
     Type:  patch      |       Status:  new    
 Priority:  minor      |    Milestone:  0.21   
Component:  mythtv     |      Version:  head   
 Severity:  medium     |   Resolution:         
  Mlocked:  0          |  
-----------------------+----------------------------------------------------

Comment(by Matthew Wire <devel at mrwire.co.uk>):

 Updated patches for import icons.  This is still not fully working (see
 below) but I think it fixes all of Stuart's issues except for the hang on
 exit.[[BR]]
 [[BR]]
 '''importicons-libmyth-29092007'''[[BR]]
 ''Suggest this patch could be applied now, as is.''  It provides
 supporting changes for the import icons dialog:[[BR]]
  * Adds currentItem() method to MythListBox to retrieve currently selected
 item.[[BR]]
  * Adds definition for TransListBoxSetting()[[BR]]
  * Modifies MythProgressDialog:[[BR]]
   * Allows a cancel button to be displayed on the progress dialog
 (optional)[[BR]]
   * Adds a new method setLabel() to allow changing the progress dialog
 text while running.  Used in import icons to display current scanned icon,
 total to scan and number of icons found.  Would be useful in any scanning
 type situation when the user wants additional feedback as well as the
 progress indicator.[[BR]]
 [[BR]]
 '''importicons-libmythtv-29092007'''[[BR]]
 This patch contains the actual import icons dialog.  It's been changed a
 little since the initial patch and will download all icons it can find
 automatically - well worth applying to your tree, just have to manually
 kill mythtv-setup when it completes...[[BR]]
  * When clicking "Import Icons" in the channel editor a progress dialog
 "Initialising" appears.  This then changes to a progress dialog with
 cancel button which indicates progress and shows current icon, total icons
 and number of icons that could not be downloaded.[[BR]]
  * In the current patch the cancel button action has been cancelled out
 (lines 295,296) because I have more than 1000 channels and it was taking
 too long to get to the actual dialog for debugging.[[BR]]
 '''Issues with this patch'''[[BR]]
  * When the dialog exits mythtv-setup hangs.  Think this is something to
 do with the dialog not been properly destroyed or something but can't work
 out what.  Stuart, I don't think this is a http timeout issue.[[BR]]
  * Dialog does not exit when all icons have been skipped over.  Controls
 are greyed out and you have to manually click finish.[[BR]]
  * There is loads of extra debugging in this patch which could probably be
 removed for the release (enable mythtv-setup -v channel to utilise
 it).[[BR]]
  * Look for FIXME tag for issues...[[BR]]
 [[BR]]
 This works well enough for me and I've spent a lot of time trying to find
 the hang on exit so I'm hoping someone else will take a look at this
 bit...

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3334#comment:8>
MythTV <http://svn.mythtv.org/trac>
MythTV