[mythtv-commits] Ticket #6004: OSD RTL Languages general fix

[MythTV]

#6004: OSD RTL Languages general fix
------------------------------------------------------+---------------------
 Reporter:  Tony Arie Kolev <kolevtony at bezeqint.net>  |        Owner:  ijr       
     Type:  defect                                    |       Status:  new       
 Priority:  major                                     |    Milestone:  0.21.1    
Component:  mythtv                                    |      Version:  0.21-fixes
 Severity:  medium                                    |   Resolution:            
  Mlocked:  0                                         |  
------------------------------------------------------+---------------------

Comment(by Tony Arie Kolev <kolevtony at bezeqint.net>):

 Hello, Ido,

 First, about the Segmentation Faults (#5640) people experienced  - I have
 never experienced it, what I can say is that It is probably introduced
 when in patch #4885 You return reference to a local variable - I mean the
 commented QDeepCopy and returned reference to free memory (I remember from
 my c language study that locally defined variables memory is freed when
 function returns - do You think so? (the code from patch #4885):

      QString output = rtl_string_composer.join("");

         479

         480     //    return QDeepCopy<QString>(output);

         481         return output;

 So the output can be anything - not so good.

 It is just a guess , of course , that Segmentation Faults was introduced
 by this.


 In my patch I am not doing thinks like that.

 Second, maybe You are right theoretically, practically in existent
 program, it was easier and more effectively to me to do it that way.
 Please, feel free to make fixes, the way You like it.


 When this #6004 will be in status other than new?
 Hello , is the anybody out there?

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6004#comment:5>
MythTV <http://www.mythtv.org/>
MythTV