[mythtv-commits] Ticket #5673: The ctor for Eventing in libmythupnp is missing some member initialization

MythTV mythtv at cvs.mythtv.org
Wed Dec 24 15:13:58 UTC 2008


#5673: The ctor for Eventing in libmythupnp is missing some member initialization
---------------------------------------------+------------------------------
 Reporter:  Erik Hovland <erik at hovland.org>  |        Owner:  ijr    
     Type:  defect                           |       Status:  closed 
 Priority:  trivial                          |    Milestone:  unknown
Component:  mythtv                           |      Version:  head   
 Severity:  low                              |   Resolution:  fixed  
  Mlocked:  0                                |  
---------------------------------------------+------------------------------
Changes (by danielk):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 (In [19444]) Fixes #5673. Fixes ctor for Eventing.

 Note: I also added a warning on m_nHoldCount exceeding 127 (the
 guarranteed maximum in the range of a short) My impression is that the
 author meant to use a int16_t not a short (or he would have probably just
 used a signed char which has the same guarrantees as short.) If so nKey in
 SubscriberInfo is probably a more immediate problem, since it can have a
 range anywhere from 0..255 to 0..4294967295 on typical machines and the
 actual valid range is defined by a UPnP spec.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/5673#comment:1>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list