[mythtv-commits] Ticket #3910: Mythshutdown cleanup

MythTV mythtv at cvs.mythtv.org
Tue Dec 30 23:23:32 UTC 2008


#3910: Mythshutdown cleanup
-----------------------------------------------+----------------------------
 Reporter:  Matthew Wire <devel at mrwire.co.uk>  |        Owner:  danielk
     Type:  patch                              |       Status:  closed 
 Priority:  minor                              |    Milestone:  unknown
Component:  mythtv                             |      Version:  head   
 Severity:  medium                             |   Resolution:  wontfix
  Mlocked:  0                                  |  
-----------------------------------------------+----------------------------
Changes (by danielk):

  * status:  assigned => closed
  * resolution:  => wontfix


Comment:

 Matthew, I'm sorry you have put so much effort into this. I'm not going to
 apply the isRunning patch because moving it to util.h might encourage
 others to use it, and it is just not a good idea (see the comment I added
 to it in [19505].) And the DB settings code changes may be fine, but I
 don't think the small code savings in mythshutdown are worth a potentially
 destabilizing change to one of the core methods of MythContext. I hope
 this isn't too discouraging, we really like it when people send patches
 and keep them up to date to boot!

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3910#comment:10>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list