[mythtv-commits] Ticket #3642: "Program guide in live tv" keybinding overrides guide jump point

MythTV mythtv at cvs.mythtv.org
Sat Feb 2 11:23:52 UTC 2008


#3642: "Program guide in live tv" keybinding overrides guide jump point
-------------------------+--------------------------------------------------
 Reporter:  anonymous    |        Owner:  cpinkham
     Type:  enhancement  |       Status:  assigned
 Priority:  minor        |    Milestone:  0.21    
Component:  mythtv       |      Version:  head    
 Severity:  medium       |   Resolution:          
  Mlocked:  0            |  
-------------------------+--------------------------------------------------

Comment(by Roo <roo.watt at gmail.com>):

 Replying to [comment:14 cpinkham]:
 > Roo, can you try the patch attached called
 'localAction_over_jumppoint_v1.diff'.  I believe it accomplishes what you
 are trying to do in a better way.
 So do I, some comments follow:

  * I '''like''' the generality of your approach, much nicer :)
  * I wonder if there is a need to extend the jumppoint table with the
 extra column? Just leave the localactions defined in code, if in the
 future the local actions are changed (in code) then the db wouldn't need
 to be updated.
  * If the keybinding and the jumppoint are set to different keys then the
 jumppoint still gets used, bit awkward in the setup aspect.

  I wonder if it is worth registering a "context,action" pair, then
 !TranslateKeyPress() could check the context and return the matching local
 action instead of the jumppoint.

 This would have the added advantage that the local keybinding doesn't have
 to be the same as the jumppoint. Actually, there would be no need to have
 the "TV Frontend" GUIDE action bound if you have the GUIDE jumppoint set.
 This was one of the things I liked about the alternate approach.

 Anyway, thanks for looking into this. I am keen for this to make 0.21 as
 it does come up a fair bit on the mailing lists.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3642#comment:16>
MythTV <http://svn.mythtv.org/trac>
MythTV


More information about the mythtv-commits mailing list