[mythtv-commits] Ticket #3618: LiveTV Safeguards

MythTV mythtv at cvs.mythtv.org
Fri Feb 22 17:50:16 UTC 2008


#3618: LiveTV Safeguards
---------------------+------------------------------------------------------
 Reporter:  stuartm  |        Owner:  ijr    
     Type:  task     |       Status:  new    
 Priority:  minor    |    Milestone:  unknown
Component:  mythtv   |      Version:  head   
 Severity:  medium   |   Resolution:         
  Mlocked:  0        |  
---------------------+------------------------------------------------------

Comment(by Shane Shrybman <gnome42 at gmail.com>):

 The first patch is a real fix I think. The second patch depends on the
 first but is only a safeguard against endless NeedsToSwitch/NeedsToJump
 loops.

 The endless JumpTo loop scenario goes like this ...

 Once NeedsToJump is set in livetvchain it is only cleared by GetJumpPos().
 But livetvchain->GetSwitchProgram() can return NULL, if we're already on
 the correct
 entry or it can't find the program which means an early return from
 NVP::JumpToProgram()
 and GetJumpPos() is never called and we loop forever.

 The mythtv_NVP_GetJumpPos.diff patch addresses this by moving the call to
 GetJumpPos() to before GetSwitchProgram() so that NeedsToJump is always
 cleared.

 The second patch for LiveTVChain::GetSwitchProgram() ensures that both
 NeedsToJump and NeedsToSwitch are always cleared in GetSwitchProgram().
 The comment above GetSwitchProgram() already stated this was true but it
 didn't actually clear NeedsToJump and didn't clear NeedsToSwitch in all
 cases. This should provide a bit of a safeguard against endless loops.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3618#comment:1>
MythTV <http://svn.mythtv.org/trac>
MythTV


More information about the mythtv-commits mailing list