[mythtv-commits] Ticket #4844: don't dereference this if it doesn't exist in dvdnav_internal.h
MythTV
mythtv at cvs.mythtv.org
Mon Mar 3 21:29:25 UTC 2008
#4844: don't dereference this if it doesn't exist in dvdnav_internal.h
---------------------------------------------+------------------------------
Reporter: Erik Hovland <erik at hovland.org> | Owner: ijr
Type: defect | Status: new
Priority: minor | Milestone: 0.21
Component: mythtv | Version: 0.21-fixes
Severity: low | Mlocked: 0
---------------------------------------------+------------------------------
In dvdnav_internal.h, printerr is defined as:
{{{
#define printerr(str) strncpy(this->err_str, str, MAX_ERR_LEN);
}}}
Unfortunately, all over the code functions call:
{{{
if(!this) {
printerr("Passed a NULL pointer.");
return DVDNAV_STATUS_ERR;
}
}}}
Which means that instead of printing an error it will try to dereference a
null pointer and segfault.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/4844>
MythTV <http://svn.mythtv.org/trac>
MythTV
More information about the mythtv-commits
mailing list