[mythtv-commits] Ticket #5667: Commercial autoskip/notify does not always recognize beginning of commbreak
MythTV
mythtv at cvs.mythtv.org
Thu Sep 4 19:50:04 UTC 2008
#5667: Commercial autoskip/notify does not always recognize beginning of commbreak
----------------------------------+-----------------------------------------
Reporter: otto at kolsi dot fi | Owner: ijr
Type: defect | Status: new
Priority: minor | Milestone: unknown
Component: mythtv | Version: 0.21-fixes
Severity: medium | Mlocked: 0
----------------------------------+-----------------------------------------
I have some recordings that have been flagged successfully by
mythcommflag. However, when playing these recordings NuppelVideoPlayer
does not recognize the beginnig of the commbreak and does not autoskip or
notify the commbreak.
If the beginning of commbreak is missed but I manually jump to end of
commbreak it works fine. Also if I load the skip positions to edit
recordings screen, the beginnings of the commbreaks are in right
positions.
If recording is fast forwarded or jumped/skipped, the problem does not
occur. This slows down the debugging since I have to really play the
recording from the beginning until to the problematic position.
I've added some debugging prints to
NuppelVideoPlayer::AutoCommercialSkip() and noticed that e.g. when the
beginning of commbreak is at frame 41012, when that position is reached
the commBreakIter has probably been incremented one time too much and it
is pointing already to the beginning of the next commbreak and thus the
jump/notify does not occur:
{{{2008-09-04 22:22:40.612 NVP: DEBUG*** AutoCommercialSkip data: 4,
framesPlayed: 41012, key: 71307}}}
With this particular recording, the recording starts with a commbreak and
I manually jump to the end of that commbreak when starting to watch the
recording. Not sure if this step in the beginning has something to do with
the problem.
I'll try to dig some more but any additional help is also appreciated.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/5667>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list