[mythtv-commits] Ticket #7692: Autoexpire no longer gracefully deals with missing recordings

[MythTV]

#7692: Autoexpire no longer gracefully deals with missing recordings
---------------------------------------------+------------------------------
 Reporter:  Marc Randolph <mrand@…>          |       Owner:  ijr    
     Type:  defect                           |      Status:  new    
 Priority:  minor                            |   Milestone:  unknown
Component:  MythTV - General                 |     Version:  unknown
 Severity:  medium                           |     Mlocked:  0      
---------------------------------------------+------------------------------
 Forwarding from downstream:

 Summary is that the AutoExpire in 0.21 checked that each expire succeeds
 and if it doesn't tries another file.  That appears to be broken in 0.22.

 First here's a log from 0.21 where autoexpire ran during a recording
 (extra required set to 1gb):

 2009-09-18 03:36:28.229 AutoExpire: CalcParams(): Max required Free Space:
 2.0 GB w/freq: 15 min
 2009-09-18 03:36:28.324 ProgramInfo, Error: GetPlaybackURL:
 '1061_20090903220000.mpg' should be local, but it can not be found.
 2009-09-18 03:36:28.327 Expiring 4452 MBytes for 1038 @ Sun Sep 6 00:00:00
 2009 => Babe

 notice how it failed to delete the first file, but got a round this by
 deleting a second.

 Now here's a similar log from 0.22 (extra required set to 5gb):

 2009-11-27 14:59:13.207 AutoExpire: CalcParams(): Max required Free Space:
 6.0 GB w/freq: 15 min
 2009-11-27 14:59:13.307 ProgramInfo, Error: GetPlaybackURL:
 '1061_20090903220000.mpg' should be local, but it can not be found.

 This time notice how it only attempted to delete a single file (and this
 failed); subsequent logs show it making further attempts to delete that
 same file.  Eventually either the disk fills (what I was seeing), or auto-
 expire detects that to free up the required space it should delete
 multiple files.

 Most obvious cause of this would be a program or system crash, or the file
 somehow being accidentally deleted.  Regardless, filling up the hard drive
 is a pretty harsh punishment for someone not manually catching this -
 especially if they weren't aware that the crash happened to begin with (if
 mythbackend is auto-restarted, for example).

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7692>
MythTV <http://www.mythtv.org/>
MythTV