[mythtv-commits] Ticket #7791: mythgallery mark/unmark single/all files

[MythTV]

#7791: mythgallery mark/unmark single/all files
----------------------------------+-----------------------------------------
 Reporter:  Robert S              |       Owner:  ijr           
     Type:  patch                 |      Status:  infoneeded_new
 Priority:  minor                 |   Milestone:  0.22          
Component:  Plugin - MythGallery  |     Version:  head          
 Severity:  low                   |     Mlocked:  0             
----------------------------------+-----------------------------------------
Changes (by stuartm):

  * status:  new => infoneeded_new


Comment:

 Robert, Thank you for taking the time to submit your patches.

 No for the feedback. It's not acceptable to replace the event driven menu
 with slots, the latter is deprecated because it's considered less safe. As
 implemented in MythGallery it might be a little untidy but that's no
 reason to make a change that is unrelated to your proposed feature.

 I'm also unsold on the need for the change to MythUIButtonList. As
 supplied it's a sure fire recipe for segfaults since at no point do you
 check that pos is actually valid (Mark called on an empty list etc).

 {{{
 MythUIButtonListItem *item = m_imageList->GetItemCurrent();
 if (!item)
     return;
 item->SetChecked(MythUIButtonListItem::FullChecked);
 }}}

 Achieves the same thing with no changes to MythUIButtonList and consistent
 with the usage of MythUIButtonList everywhere else.

 If you can resubmit the patches without the unnecessary changes then we
 can take another look.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7791#comment:2>
MythTV <http://www.mythtv.org/>
MythTV