[mythtv-commits] Ticket #6266: bug in vdpau advanced deinterlacing

[MythTV]

#6266: bug in vdpau advanced deinterlacing
-------------------------------------+--------------------------------------
 Reporter:  Andy Cohen               |       Owner:  ijr 
     Type:  defect                   |      Status:  new 
 Priority:  minor                    |   Milestone:  0.22
Component:  MythTV - Video Playback  |     Version:  head
 Severity:  medium                   |     Mlocked:  0   
-------------------------------------+--------------------------------------
 I may have found a bug in VDPAU deinterlacing. For reference I am
 using a motherboard with integrated nvidia geforce 9400 graphics.
 Deinterlacing with Temporal (2x, hw) works fine, but Advanced (2x, hw)
 gives a slightly juddery image. These deinterlacing methods are
 selected by passing enable flags through
 vdp_video_mixer_set_feature_enables().  In the Temporal case, the flag to
 enable VDP_MIXER_FEATURE_DEINTERLACE_TEMPORAL is passed. In the Advanced
 case the flag for
 VDP_MIXER_FEATURE_DEINTERLACE_TEMPORAL_SPATIAL should be passed, but
 the code in util-vdpau.cpp actually passes BOTH of these flags. According
 to the Nvidia docs this should be OK: "When multiple
 de-interlacing options are requested and enabled, the back-end
 implementation chooses the best algorithm to apply." However it isn't OK,
 at least on this IGP---when I pass ONLY the flag to enable
 VDP_MIXER_FEATURE_DEINTERLACE_TEMPORAL_SPATIAL then I get a fine,
 non-juddery image, while passing both flags leads to the judder.

 There doesn't seem to be much reason to pass both flags, so the simple fix
 is to pass only one flag or the other. A (trivial) patch to do this is
 attached.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6266>
MythTV <http://www.mythtv.org/>
MythTV