[mythtv-commits] Ticket #6405: PATCH: Mutex locking bug in dvbstreamhandler.cpp

[MythTV]

#6405: PATCH: Mutex locking bug in  dvbstreamhandler.cpp
---------------------------------------+------------------------------------
 Reporter:  tomimo at ncircle.nullnet.fi  |       Owner:  ijr 
     Type:  patch                      |      Status:  new 
 Priority:  minor                      |   Milestone:  0.22
Component:  MythTV - General           |     Version:  head
 Severity:  medium                     |     Mlocked:  0   
---------------------------------------+------------------------------------
 The patch below fixes an obvious potential deadlock (happened here once
 already).


 {{{
 Index: libs/libmythtv/dvbstreamhandler.cpp
 ===================================================================
 --- libs/libmythtv/dvbstreamhandler.cpp (revision 20282)
 +++ libs/libmythtv/dvbstreamhandler.cpp (working copy)
 @@ -200,9 +200,9 @@ void DVBStreamHandler::Start(void)
              return;
          }

 +        is_running_lock.lock();
          while (!IsRunning())
          {
 -            is_running_lock.lock();
              _running_state_changed.wait(&is_running_lock, 100);
          }
      }

 }}}

 Regards,
 Tomi Orava

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/6405>
MythTV <http://www.mythtv.org/>
MythTV