[mythtv-commits] Ticket #6582: Exclude special groups from disk space reporting
MythTV
mythtv at cvs.mythtv.org
Tue May 26 19:47:17 UTC 2009
#6582: Exclude special groups from disk space reporting
----------------------------------------------+-----------------------------
Reporter: sphery <mtdean at thirdcontact.com> | Owner: ijr
Type: patch | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - General | Version: head
Severity: medium | Mlocked: 0
----------------------------------------------+-----------------------------
The attached patch expands the list of storage groups excluded in the disk
space reporting (as originally introduced in [19695] ). The patch simply
excludes every storage group specified in StorageGroup::kSpecialGroups .
With the proliferation of special groups (LiveTV, DB Backups, Videos,
Trailers, Coverart, Fanart, Screenshots, Banners), the status page can
become quite a mess (and its total misleading) without the patch.
Note that this is still a bit of a hack. A better approach would rely on
storage group types, but until that's implemented, this approach works
since all currently-existing special storage groups are non-TV groups.
I did not use a prepared statement to include the list of group names in
the query since doing so would require dynamically adding placeholders (as
each placeholder is treated as a single element, so it's impossible to add
a list with a single placeholder). Currently this works fine since none
of the special groups have single quotes (or other database-special
characters). If that changes in the future, this code will have to be
changed. If you'd prefer the prepared statement approach, please let me
know.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6582>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list