[mythtv-commits] Ticket #6478: Add update timestamp to program table for incremental program data retrieval
MythTV
mythtv at cvs.mythtv.org
Wed May 27 14:23:08 UTC 2009
#6478: Add update timestamp to program table for incremental program data
retrieval
---------------------------------------+------------------------------------
Reporter: chasedouglas at gmail.com | Owner: danielk
Type: patch | Status: infoneeded
Priority: minor | Milestone: unknown
Component: MythTV - Mythfilldatabase | Version: head
Severity: medium | Resolution:
Mlocked: 0 |
---------------------------------------+------------------------------------
Comment(by anonymous):
Replying to [comment:6 danielk]:
> Chase, I think you need too look at this a bit more. There are SQL
statements prepared but not executed in datadirect.cpp and there is a file
missing in the patch (but I was able to reconstruct it for testing.)
There are three queries prepared in datadirect.cpp, and all three are
executed. If they weren't it wouldn't work right at all.
What file is missing?
> Also, why is the program table treated differently from the other
related tables in ProgramData::clearDataByChannel() ?
The current clearDataByChannel() code completely deletes all the program
information in the channel. Currently, mythtv deletes all program
information, and then reloads it all back in. We want to leave the program
information and just update it with what has changed since the last
mythfilldatabase run.
> Did you do before and after benchmarking for this? What kind of numbers?
I have not yet, but I will try to soon.
> DataDirectProgramUpdate() will give us overlaps if there is pre-existing
non-DataDirect data in the table, unless I'm missing something?
If DataDirect is not the preferred listings source then it won't delete
the pre-existing non-DataDirect programs in the first query of the
function. During the update, the temporary table dd_v_program holds all
the programs that will be copied into the real program table. The third
query in DataDirectProgramUpdate() deletes any programs in dd_v_program
that would overlap with any pre-existing programs that weren't cleared
away by the first query in the function.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6478#comment:7>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list