[mythtv-commits] Ticket #7232: DVB scanning channels fails with error parsing parameters

[MythTV]

#7232: DVB scanning channels fails with error parsing parameters
------------------------------------------------+---------------------------
 Reporter:  Tim Jordan <tim at wheresrover.co.uk>  |        Owner:  ijr    
     Type:  defect                              |       Status:  new    
 Priority:  minor                               |    Milestone:  unknown
Component:  MythTV - General                    |      Version:  unknown
 Severity:  medium                              |   Resolution:         
  Mlocked:  0                                   |  
------------------------------------------------+---------------------------

Comment(by mythtv at dadeos.co.uk):

 I am experiencing the same problem.

 I have identified the cause on my system to be problems with
 {{{DTVTunerType::kTunerTypeUnknown}}} being defined as {{{0x8000000}}},
 which gcc 4.3.3 wishes to represent as an unsigned value on my 32-bit
 system. Commit #21935 attempted to resolve the signed/unsigned comparison
 compiler warnings, however this change breaks comparisons with
 {{{DTVTunerType::kTunerTypeUnknown}}} on my system. i.e. the code in
 {{{ScanWizard::SetPage()}}} from {{{libs/libmythtv/scanwizard.cpp}}}

 {{{
     DTVTunerType parse_type = DTVTunerType::kTunerTypeUnknown;
     if (parse_type != DTVTunerType::kTunerTypeUnknown)
     {
         // This code gets executed (which is wrong!!)
     }
 }}}

 The attached patch resolves these problems by eliminating the comparison
 operators from the {{{DTVTunerType}}} class.

 The patch additionally removed the comparison operators from the
 {{{DTVParamHelper}}} class, as they are unnecessary, and removes the need
 for {{{DTVTunerType::initStr()}}} function, which was extremely
 inefficient.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7232#comment:1>
MythTV <http://www.mythtv.org/>
MythTV