[mythtv-commits] mythtv commit: r22288 by cpinkham

[mythtv at cvs.mythtv.org]

      Author: cpinkham
        Date: 2009-10-07 03:05:04 +0000 (Wed, 07 Oct 2009)
New Revision: 22288
   Changeset: http://cvs.mythtv.org/trac/changeset/22288

Modified:

   trunk/mythtv/libs/libmythui/mythuiimage.cpp

Log:

Another couple MythUIImage threading fixes.

- Put a lock around a QImage copy that runs inside the thread.
  QImage is reentrant but not thread safe according to the docs.

- Inside the MythUIImage destructor, call QThreadPool::waitForDone()
  on our image thread pool so that we don't yank a MythUIImage
  out from under a queued thread.  If you perform the MythVideo
  torture test of clearing the fanart cache and quickly scrolling
  through all the videos, you'll now have a slight delay trying to
  exit the screen if there are any queued image loading threads
  waiting to be processed.  We will revisit the threading
  architecture after 0.22 and possibly implement a better solution,
  but for now this should clear up any issues related to a MythUIImage
  being deleted out from under a queued or running thread.