[mythtv-commits] Ticket #7291: Screensaver not reset in a timely fashion

[MythTV]

#7291: Screensaver not reset in a timely fashion
---------------------------------------------+------------------------------
 Reporter:  mythtv at cjo20.net                 |       Owner:  stuartm
     Type:  defect                           |      Status:  new    
 Priority:  minor                            |   Milestone:  unknown
Component:  MythTV - User Interface Library  |     Version:  unknown
 Severity:  medium                           |     Mlocked:  0      
---------------------------------------------+------------------------------
 While watching a ripped DVD (in VIDEO_TS format), the screensaver does not
 appear to be disabled properly.

 2009-10-11 02:53:12.051 ScreenSaverX11Private: Calling xscreensaver-
 command -deactivate

 2009-10-11 02:53:12.065 ScreenSaverX11Private: Calling gnome-screensaver-
 command --poke


 The above commands appear in the output of mythfrontend -v playback every
 50 seconds or so (screensaver is set to blank screen after 1 minute). This
 appears to work correctly, until a DVDNAV_CELL_CHANGE occurs. At some
 point over the next minute, the screensaver will activate, and then at
 about a minute after the DVDNAV_CELL_CHANGE, the screensaver will
 deactivate itself.

 I believe that this is due to the reset of the timer that occurs shortly
 after the DVDNAV_CELL_CHANGE

 2009-10-11 02:51:32.042 ScreenSaverX11Private: ResetTimer -- begin

 2009-10-11 02:51:32.042 ScreenSaverX11Private: StopTimer

 2009-10-11 02:51:32.042 ScreenSaverX11Private: StartTimer

 2009-10-11 02:51:32.042 ScreenSaverX11Private: ResetTimer -- end


 From a short look at the code, my understanding is that the ResetTimer
 function starts the countdown before the next --disable or --poke from the
 beginning, but doesn't do anything to stop the screensaver from
 activating.

 An example timeline:

 00:00:00 screensaver --disable and --poke

 00:00:45 ScreenSaverX11Private: ResetTimer

 00:01:00 Screensaver is activated here (1 min since last --poke)

 00:01:45 screensaver --disable and --poke. Screensaver is deactivated here
 (1 min since timer reset)

 I am not familiar with the code, so I can't be sure whether there is an
 issue with a poke of the screensaver failing in the function that calls
 ResetTimer, or whether it is a problem with ResetTimer itself.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7291>
MythTV <http://www.mythtv.org/>
MythTV