[mythtv-commits] Ticket #7392: Audio resampling errors on Mac OS X

[MythTV]

#7392: Audio resampling errors on Mac OS X
-----------------------------------+----------------------------------------
 Reporter:  nigel                  |       Owner:  jyavenard
     Type:  defect                 |      Status:  new      
 Priority:  minor                  |   Milestone:  unknown  
Component:  MythTV - Audio Output  |     Version:  head     
 Severity:  medium                 |     Mlocked:  0        
-----------------------------------+----------------------------------------

Comment(by nigel):

 Build is OK. NuppleVideo recordings can (do?) exhibit codec=NONE.
 [[BR]]
 Problem is failure of, or unimplemented, GetSupportedRates(). This change:
 {{{
 % svn diff audiooutputbase.cpp
 Index: audiooutputbase.cpp
 ===================================================================
 --- audiooutputbase.cpp (revision 22559)
 +++ audiooutputbase.cpp (working copy)
 @@ -271,6 +271,10 @@
      vector<int>::iterator it;
      bool resample = true;

 +    // Assume 48k if we can't get supported rates
 +    if (rates.empty())
 +        rates.push_back(48000);
 +
      for (it = rates.begin(); it < rates.end(); it++)
      {
          VERBOSE(VB_AUDIO, LOC + QString("Sample rate %1 is supported")
 @@ -279,10 +283,6 @@
              resample = false;
      }

 -    // Assume 48k if we can't get supported rates
 -    if (rates.empty())
 -        rates.push_back(48000);
 -
      if (resample)
      {
          int error;
 }}}
 gives me working audio:
 {{{
 2009-10-22 13:55:38.450 CoreAudioData::CoreAudioData - default device ID =
 262
 2009-10-22 13:55:38.450 AO: Killing AudioOutputDSP
 2009-10-22 13:55:38.450 AO: Original audio codec was NONE
 2009-10-22 13:55:38.450 AO: Sample rate 48000 is supported
 2009-10-22 13:55:38.450 Opening audio device 'Default'. ch 2(2) sr 48000
 (reenc 0)
 2009-10-22 13:55:38.450 AudioOutputCA::OpenDevice() Trying Analog.
 2009-10-22 13:55:39.012 AO: Audio fragment size: 0
 2009-10-22 13:55:39.013 AO: Audio Stretch Factor: 1
 2009-10-22 13:55:39.013 AO: Ending reconfigure
 2009-10-22 13:55:39.013 AO: no change exiting
 2009-10-22 13:55:39.017 AO: no change exiting
 2009-10-22 13:55:39.018 AO: Pause 1
 ...
 }}}

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7392#comment:2>
MythTV <http://www.mythtv.org/>
MythTV