[mythtv-commits] Ticket #7015: Remove or rework dead code in Myth UI

MythTV mythtv at cvs.mythtv.org
Tue Sep 8 15:11:55 UTC 2009


#7015: Remove or rework dead code in Myth UI
---------------------------------------------+------------------------------
 Reporter:  Erik Hovland <erik at hovland.org>  |       Owner:  stuartm
     Type:  defect                           |      Status:  new    
 Priority:  trivial                          |   Milestone:  unknown
Component:  MythTV - User Interface Library  |     Version:  head   
 Severity:  low                              |     Mlocked:  0      
---------------------------------------------+------------------------------
 1. Once the use-after-free patch is applied, the check at line 913
    in lirc_client.c is no longer necessary.
 2. The check of sockfd is not necessary. sockfd was closed
    before the goto was called.
 3. vdest.x0 and y0 are unsigned. So checking for < 0 will never be
    true. Fortunately r.x() returns a signed value. So check at
    assignment instead.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7015>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list