[mythtv-commits] Ticket #7136: PreviewGenerator when no backend binary

[MythTV]

#7136: PreviewGenerator when no backend binary
------------------------------+---------------------------------------------
 Reporter:  nigel             |       Owner:  ijr    
     Type:  patch             |      Status:  new    
 Priority:  minor             |   Milestone:  unknown
Component:  MythTV - General  |     Version:  head   
 Severity:  medium            |     Mlocked:  0      
------------------------------+---------------------------------------------
 If an install has no backend binary, going into Watch Recordings can
 output lots of errors like:
 {{{
 2009-09-24 20:54:54.246 Preview Error: Encountered problems running
 '/Volumes/MythBuild/.osx-packager/src/myth-
 svn/mythtv/programs/Resources/bin/mythbackend --generate-preview 0x0
 --chanid 1004 --starttime 20080206182700 '
 sh: line 1: /Volumes/MythBuild/.osx-packager/src/myth-
 svn/mythtv/programs/Resources/bin/mythbackend: No such file or directory
 2009-09-24 20:54:54.276 Preview Error: Encountered problems running
 '/Volumes/MythBuild/.osx-packager/src/myth-
 svn/mythtv/programs/Resources/bin/mythbackend --generate-preview 0x0
 --chanid 1039 --starttime 20071029102347 '
 sh: line 1: /Volumes/MythBuild/.osx-packager/src/myth-
 svn/mythtv/programs/Resources/bin/mythbackend: No such file or directory
 }}}
 (Mac frontend-only packages only have mythfrontend and mtd). This patch
 checks for the binary before trying to invoke it:
 {{{
 Index: previewgenerator.cpp
 ===================================================================
 --- previewgenerator.cpp        (revision 22017)
 +++ previewgenerator.cpp        (working copy)
 @@ -223,8 +223,12 @@
      else
      {
          // This is where we fork and run mythbackend to actually make
 preview
 -        QString command = GetInstallPrefix() +
 -                                    "/bin/mythbackend --generate-preview
 ";
 +        QString command = GetInstallPrefix() + "/bin/mythbackend";
 +
 +        if (!QFileInfo(command).exists())
 +            return false;
 +
 +        command += " --generate-preview ";
          command += QString("%1x%2")
              .arg(outSize.width()).arg(outSize.height());
          if (captureTime >= 0)
 }}}

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7136>
MythTV <http://www.mythtv.org/>
MythTV