[mythtv-commits] Ticket #7144: Multirec with HDHR closes video stream when recordings overlap

[MythTV]

#7144: Multirec with HDHR closes video stream when recordings overlap
------------------------------------+---------------------------------------
 Reporter:  david.madsen at gmail.com  |        Owner:  danielk
     Type:  defect                  |       Status:  new    
 Priority:  minor                   |    Milestone:  unknown
Component:  MythTV - Recording      |      Version:  head   
 Severity:  medium                  |   Resolution:         
  Mlocked:  0                       |  
------------------------------------+---------------------------------------

Comment(by david.madsen at gmail.com):

 While looking through the logs I also noticed that the refcount for the
 HDHRStreamHandler never decremented.  Traced it back to here where the
 iterators are dereferenced and decremented, but since there were no
 parenthesis to force the order of operations, it was actually decrementing
 the iterator instead.

 Index: hdhrstreamhandler.cpp
 ===================================================================
 --- hdhrstreamhandler.cpp       (revision 21864)
 +++ hdhrstreamhandler.cpp       (working copy)
 @@ -78,7 +78,7 @@
      if (*rit > 1)
      {
          ref = NULL;
 -        *rit--;
 +        (*rit)--;
          return;
      }

 Index: dvbstreamhandler.cpp
 ===================================================================
 --- dvbstreamhandler.cpp        (revision 21864)
 +++ dvbstreamhandler.cpp        (working copy)
 @@ -66,7 +66,7 @@
      if (*rit > 1)
      {
          ref = NULL;
 -        *rit--;
 +        (*rit)--;
          return;
      }

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7144#comment:1>
MythTV <http://www.mythtv.org/>
MythTV