[mythtv-commits] mythtv commit: r23993 - in trunk/mythtv by mdean

[mythtv at cvs.mythtv.org]

      Author: mdean
        Date: 2010-04-05 00:34:37 +0000 (Mon, 05 Apr 2010)
New Revision: 23993
   Changeset: http://svn.mythtv.org/trac/changeset/23993

Modified:

   trunk/mythtv/libs/libmythtv/NuppelVideoPlayer.cpp
   trunk/mythtv/libs/libmythtv/previewgenerator.cpp
   trunk/mythtv/programs/mythbackend/mythxml.cpp
   trunk/mythtv/programs/mythfrontend/globalsettings.cpp

Log:

Smart preview pixmap offset.

Calculate the default preview pixmap offset, taking into account program duration and actual recording start time (including start early and time to record before start of show), as well as commercial flag list and cut list.

Removes redundant MythXML code that calculated the default offset and instead relies on the code in the preview generator.  This, plus the recent changes to MythWeb, means there's only one location in MythTV where the default preview pixmap offset is calculated.

Removes the PreviewPixmapOffset setting, which is no longer useful, now that each recording gets a customized offset.  In my testing, the new algorithm was significantly more reliable at finding good previews than the one-size-fits-all setting we used previously (whether at the default value or "tuned"), which used the exact same offset for every recording.