[mythtv-commits] Ticket #8036: MTD: Error getting volume name, setting to "Unknown"

[MythTV]

#8036: MTD: Error getting volume name, setting to "Unknown"
------------------------------------------------+---------------------------
 Reporter:  jason.chambers@…                    |       Owner:  awithers  
     Type:  patch                               |      Status:  new       
 Priority:  minor                               |   Milestone:  unknown   
Component:  Plugin - MythVideo                  |     Version:  0.22-fixes
 Severity:  medium                              |     Mlocked:  0         
------------------------------------------------+---------------------------
 When importing a DVD using MTD (Myth Transcoding Daemon) on 0.22-fixes,
 the "Name" field is no longer populated with the DVD Volume name like it
 used to on 0.21.

 The "Name" field just contains "Unknown" (or "Unknown - Title ...") and
 the mtd.log file contains the message:

     Error getting volume name, setting to "Unknown"

 This occurs because UDFGetDescriptor() returns with a false value in
 mythtv/libs/libmythdvdnav/dvdread/dvd_udf.c at line 888:

   if(bufsize < DVD_VIDEO_LB_LEN)
     return 0;

 The value passed for the bufsize argument appears to be wrong - its
 passing sizeof(pointer) rather than sizeof(array).

 This was fixed previously in changeset [9818] (back in 2006), but looks
 like it was undone in the re-sync with libdvdnav in changeset [19956]

 Attached is a patch to restore the previous bufsize calculation assuming
 its still valid for the current code.  It works on my 0.22-fixes frontends
 without any problems so far, but my C is very rusty so I don't know if its
 correct.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/8036>
MythTV <http://www.mythtv.org/>
MythTV