[mythtv-commits] Ticket #8006: segfault in frontend after deleting recordings
MythTV
mythtv at cvs.mythtv.org
Thu Feb 25 21:16:05 UTC 2010
#8006: segfault in frontend after deleting recordings
----------------------------------------------+-----------------------------
Reporter: Paul Kendall <paul@…> | Owner: danielk
Type: defect | Status: closed
Priority: blocker | Milestone: 0.23
Component: MythTV - General | Version: head
Severity: medium | Resolution: fixed
Mlocked: 0 |
----------------------------------------------+-----------------------------
Changes (by danielk):
* status: assigned => closed
* resolution: => fixed
Comment:
(In [23599]) Fixes #8006. Refs #7195. Fixes some regressions in preview
generation. Most importantly this addresses the segfault. But it also
removes some of the cruft in the PreviewGenerator constructor that had
built up to deal with places that called the preview generator without
setting pathname as per the PreviewGenerator documentation. This means we
aren't doing the very expensive StorageGroup search quite as many times.
This also saves the pathname after doing a StorageGroup search in the
PlaybackBoxHelper.
There are still a number of ways left to speed up the PreviewGenerator:
For instance, using fork instead of running an external program to get
fault tolerance, which will also address #7136. We also do not need to
open a new command socket if we convert the backend preview generation to
use a non-blocking call and just send a MythEvent when we're done. But I
wanted to limit this commit to really only fix regressions since we're in
feature freeze (the pathname saving is pbbh is a bit of a stretch, but we
actually did do this before in a different way).
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8006#comment:3>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list