[mythtv-commits] Ticket #8572: trunk and 0.23-fixes build failure in upnpcmgr with Qt 4.7.0-beta1

[MythTV]

#8572: trunk and 0.23-fixes build failure in upnpcmgr with Qt 4.7.0-beta1
---------------------------+------------------------------------------------
 Reporter:  databubble     |       Owner:  dblain    
     Type:  defect         |      Status:  new       
 Priority:  major          |   Milestone:  unknown   
Component:  MythTV - UPnP  |     Version:  Trunk Head
 Severity:  medium         |     Mlocked:  0         
---------------------------+------------------------------------------------

Comment(by databubble):

 I had a look at the code where the build is failing.  I'm not a
 programmer, but it looks to me like the function is looking up value from
 an array using a string name/index.  If the string isn't found, it should
 be returning a 0 or false or something (I think), but instead it seems to
 by trying to lookup the value of a null character - definitely odd, and I
 can see why the compiler is throwing a wobbly.

 If I change the two cases of "return T(0);" to "return 0" it compiles...
 but I don't know if is the intended return value.

 I'm sure any real programmer can look at this and, in just a couple of
 seconds, say what the function should be returning, so that I can build
 0.23-fixes and trunk again....


 From mythtv/libs/libmythupnp/eventing.h  (lines 236 & 244).

 {{{

        template < class T >
         T GetValue( const QString &sName )
         {
             SVMap::iterator it = m_map.find(sName);
             if (it == m_map.end())
             return T(0);

             StateVariable< T > *pVariable =
                 dynamic_cast< StateVariable< T > *>( *it );

             if (pVariable != NULL)
                 return pVariable->GetValue();

             return T(0);
         }

 }}}

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/8572#comment:2>
MythTV <http://www.mythtv.org/>
MythTV